Samrat002 commented on PR #27187: URL: https://github.com/apache/flink/pull/27187#issuecomment-4029434551
> I've just pushed a new commit at top of all changes. I thought it will create an internal PR against the code but seems like it has accepted as-is. Everybody, please take a deep look at it. I'm of course fine with it since I've added that 🙂 @Samrat002 if you can test it on your side and report back I would appreciate. When this part is sorted out then it's also good to go from my side. Thank you @gaborgsomogyi, for adding the change. I have tested the changes e2e with the following scenario below: | Test | Chain Log | |---|---| | Minimal (no static, no custom) | `DynamicTemporaryAWSCredentialsProvider -> DefaultCredentialsProvider` | | Static credentials | `StaticCredentialsProvider -> DynamicTemporaryAWSCredentialsProvider -> DefaultCredentialsProvider` | | Anonymous on public bucket | `AnonymousCredentialsProvider -> DynamicTemporaryAWSCredentialsProvider -> DefaultCredentialsProvider` | | All four tiers | `AnonymousCredentialsProvider -> StaticCredentialsProvider -> DynamicTemporaryAWSCredentialsProvider -> DefaultCredentialsProvider` | | Anonymous on private bucket — 403 Forbidden | `AnonymousCredentialsProvider -> DynamicTemporaryAWSCredentialsProvider -> DefaultCredentialsProvider` | | Bogus static credentials — 403 Forbidden | `StaticCredentialsProvider -> DynamicTemporaryAWSCredentialsProvider -> DefaultCredentialsProvider` | I have made a few changes to add a log and better UT related to s3ChainProvider. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
