Myracle commented on code in PR #27509:
URL: https://github.com/apache/flink/pull/27509#discussion_r2910227577
##########
flink-core/src/main/java/org/apache/flink/configuration/WebOptions.java:
##########
@@ -148,6 +148,26 @@ public class WebOptions {
.defaultValue(Duration.ofMillis(10L * 60L * 1000L))
.withDescription("Timeout for asynchronous operations by
the web monitor.");
+ /**
+ * Time-to-live for cached ExecutionGraph. If not set, defaults to the
value of {@link
+ * #REFRESH_INTERVAL}.
+ *
+ * <p>Setting this to 0 (or a very small value) means the cache will
always fetch fresh data,
Review Comment:
Good catch! You're right that the Javadoc and withDescription were
inconsistent. Looking at the DefaultExecutionGraphCache implementation, only a
value of exactly 0 deterministically disables caching (since currentTime <
currentTime is always false). A "very small value" would only probabilistically
result in cache misses, not guarantee them. I've updated the Javadoc to remove
the ambiguous "(or a very small value)" phrasing, making it consistent with the
withDescription text — both now explicitly state that setting this to 0
disables caching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
