featzhang commented on PR #27351:
URL: https://github.com/apache/flink/pull/27351#issuecomment-4035960968
@lincoln-lil Thanks for your review! I've addressed your comments:
1. Removed the boolean parameter - now we have two separate functions:
- `URL_DECODE_RECURSIVE(string)` with default max depth of 10
- `URL_DECODE_RECURSIVE(string, maxDepth)` for custom depth
2. Aligned naming in Table API: `STRING.urlDecodeRecursive()`
3. Replaced hard-coded magic number with configurable maxDepth parameter
4. Refactored do-while+break to a cleaner while loop
The latest force-push includes these changes. Let me know if you have any
further suggestions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
