[ 
https://issues.apache.org/jira/browse/FLINK-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829597#comment-15829597
 ] 

ASF GitHub Bot commented on FLINK-4693:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3150#discussion_r96811063
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
 ---
    @@ -226,27 +225,101 @@ object AggregateUtil {
               aggregates,
               groupingOffsetMapping,
               aggOffsetMapping,
    -          intermediateRowArity,
    +          intermediateRowArity + 1,// the addition one field is used to 
store time attribute
               outputType.getFieldCount)
    +
    +      case EventTimeSessionGroupWindow(_, _, gap) =>
    +        val (startPos, endPos) = if (isTimeWindow(window)) {
    --- End diff --
    
    Aren't session windows always time windows?


> Add session group-windows for batch tables    
> -------------------------------------------
>
>                 Key: FLINK-4693
>                 URL: https://issues.apache.org/jira/browse/FLINK-4693
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: sunjincheng
>
> Add Session group-windows for batch tables as described in 
> [FLIP-11|https://cwiki.apache.org/confluence/display/FLINK/FLIP-11%3A+Table+API+Stream+Aggregations].
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to