gustavodemorais commented on code in PR #27777:
URL: https://github.com/apache/flink/pull/27777#discussion_r2945156122
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/inference/CallBindingCallContext.java:
##########
@@ -354,4 +361,15 @@ private static ColumnList convertColumnList(List<SqlNode>
operands) {
.collect(Collectors.toList());
return ColumnList.of(names);
}
+
+ private static Map<String, String> convertMap(SqlCall mapCall) {
+ final List<SqlNode> operands = mapCall.getOperandList();
+ final Map<String, String> map = new LinkedHashMap<>();
+ for (int i = 0; i < operands.size(); i += 2) {
+ final String key =
SqlLiteral.unchain(operands.get(i)).getValueAs(String.class);
Review Comment:
Let's catch exceptions here and also check for nulls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
