Izeren commented on PR #27743:
URL: https://github.com/apache/flink/pull/27743#issuecomment-4073525280

   @mukul-8, I am reading through description
   > When MetricConfig.getString() is called for numeric values like 
metrics.reporter.prom.port
   
   And I wonder, wouldn't it be more appropriate to call 
MetricConfig.getInteger for properties like `port` instead of getString? It 
would handle both: "1234" and 1234.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to