davidradl commented on code in PR #35:
URL:
https://github.com/apache/flink-connector-http/pull/35#discussion_r2946056078
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/config/HttpConnectorConfigConstants.java:
##########
@@ -164,4 +164,15 @@ public final class HttpConnectorConfigConstants {
SOURCE_RETRY_EXP_DELAY_PREFIX + "max-backoff";
public static final String SOURCE_RETRY_EXP_DELAY_MULTIPLIER =
SOURCE_RETRY_EXP_DELAY_PREFIX + "backoff-multiplier";
+
+ // -------------- Error logging configuration --------------
+
+ public static final String ERROR_LOG_LEVEL = FLINK_CONNECTOR_HTTP +
"error.log.level";
Review Comment:
We already have 'http.logging.level' that dictate how much should be logged.
This includes the body in some cases.
could you raise a Jira on this one so we can see the motivation behind this
change. My thought is that is should extend or enhance the existing mechanism
rather than introduce a new logging mechanism
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
