mukul-8 commented on code in PR #27784:
URL: https://github.com/apache/flink/pull/27784#discussion_r2957796898
##########
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/pekko/ActorSystemBootstrapTools.java:
##########
@@ -251,7 +268,8 @@ public static ActorSystem startLocalActorSystem(
*/
private static ActorSystem startActorSystem(
Config config, String actorSystemName, Logger logger) {
- logger.debug("Using pekko configuration\n {}", config);
+ Map<String, String> masked =
ConfigurationUtils.hideSensitiveValues(toMap(config));
Review Comment:
Converting the entire config to a map and masking values is an expensive
operation that runs on every actor system startup, even when debug logging is
disabled. Consider wrapping this in an isDebugEnabled() check:
if (logger.isDebugEnabled()) {
Map<String, String> masked =
ConfigurationUtils.hideSensitiveValues(toMap(config));
logger.debug("Using pekko configuration\n {}", masked);
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
