ThorneANN commented on code in PR #4246:
URL: https://github.com/apache/flink-cdc/pull/4246#discussion_r2958189275


##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/assigners/MySqlSnapshotSplitAssigner.java:
##########
@@ -222,6 +222,16 @@ else if (!isRemainingTablesCheckpointed
     }
 
     private void captureNewlyAddedTables() {
+        // Binlog-only mode: no action needed in Assigner, BinlogSplitReader 
handles it
+        if (sourceConfig.isScanBinlogNewlyAddedTableEnabled()) {
+            LOG.info(
+                    "Binlog-only newly added table capture is enabled. "
+                            + "New tables matching the pattern will be 
automatically captured "
+                            + "in binlog phase without snapshot.");
+            // No action needed here, BinlogSplitReader will handle the 
auto-capture
+            return;
+        }
+

Review Comment:
   yes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to