morozov commented on code in PR #4087:
URL: https://github.com/apache/flink-cdc/pull/4087#discussion_r2960034889
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/assigners/MySqlHybridSplitAssigner.java:
##########
@@ -208,9 +206,7 @@ public void close() {
private MySqlBinlogSplit createBinlogSplit() {
final List<MySqlSchemalessSnapshotSplit> assignedSnapshotSplit =
- snapshotSplitAssigner.getAssignedSplits().values().stream()
- .sorted(Comparator.comparing(MySqlSplit::splitId))
- .collect(Collectors.toList());
+ new
ArrayList<>(snapshotSplitAssigner.getAssignedSplits().values());
Review Comment:
> ### Before Upgrade (Old Version)
>
> 3. **Reader has already received partial splits** based on the sorted
order, e.g., `[split1, split2]`
This doesn't look right. The reader has received the splits in the same
order as they were on the enumerator before the checkpoint, unsorted, so it
will be `[split3, split2]`.
> ### After Upgrade (New Version)
>
> 5. **Reader still has state `[split1, split2]`** (unchanged from
checkpoint)
The same. How is this possible? The reader doesn't sort the elements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
