Dennis-Mircea opened a new pull request, #1075:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1075
<!--
*Thank you very much for contributing to the Apache Flink Kubernetes
Operator - we are happy that you want to help us improve the project. To help
the community review your contribution in the best possible way, please go
through the checklist below, which will get the contribution into a shape in
which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA
issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are
made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the
pull request", where *FLINK-XXXX* should be replaced by the actual issue
number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following
this pattern: `[hotfix][docs] Fix typo in event time introduction` or
`[hotfix][javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes. You can read more on how we use GitHub Actions for CI
[here](https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-main/docs/development/guide/#cicd).
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
(including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
In `JobAutoScalerImpl#scale`, when the job is not in `RUNNING` state (e.g.
during a restart after a scaling decision), the method returns early but the
`finally` block unconditionally calls `applyParallelismOverrides` and
`applyConfigOverrides` on every reconciliation cycle.
While these calls are idempotent, they are redundant during the rescaling
window — the overrides were already applied to the CR spec during the scaling
cycle that triggered the restart. This produces misleading `"Applying
parallelism overrides: ..."` log messages and performs unnecessary state store
reads on every reconciliation while the job is restarting.
A `waiting` flag is introduced to skip the override application specifically
when the job is not yet in a stable running state. The flag is intentionally
scoped to only the `JobStatus != RUNNING` path, leaving all other paths
(autoscaler disabled, scaling logic execution, exceptions, `NotReadyException`)
unchanged:
- **Autoscaler disabled**: `stateStore.clearAll()` is called first, so the
subsequent `applyParallelismOverrides` reads an empty state and no-ops - kept
as-is for safety.
- **`runScalingLogic` succeeds**: Overrides must be applied - kept as-is.
- **`runScalingLogic` throws / `NotReadyException`**: The job is `RUNNING`
(passed the
status check), and there may be overrides from a previous cycle - kept
as-is.
## Brief change log
- *[flink-autoscaler]* - Added `waiting` flag in `JobAutoScalerImpl#scale`
to skip redundant `applyParallelismOverrides` and `applyConfigOverrides` calls
when the job is not in `RUNNING` state
## Verifying this change
This change does not alter observable behavior. The skipped calls were
already no-ops during the rescaling window (overrides previously applied,
idempotent operations).
Existing tests in `JobAutoScalerImplTest` (`testParallelismOverrides`,
`testAutoscalerDisabled`, `testRealizeParallelismOverridesExceptions`) cover
the override application paths for the disabled, not-running, and error
scenarios.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
no
- Core observer or reconciler logic that is regularly executed: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
