snuyanzin commented on code in PR #27794:
URL: https://github.com/apache/flink/pull/27794#discussion_r2965021393


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/materializedtable/SqlCreateOrAlterMaterializedTableConverter.java:
##########
@@ -173,6 +178,13 @@ protected MergeContext getMergeContext(
                     
SqlCreateOrAlterMaterializedTableConverter.this.getQueryResolvedSchema(
                             sqlCreateMaterializedTable, context);
 
+            @Override
+            public boolean hasSchemaDefinition() {
+                final SqlNodeList sqlNodeList = 
sqlCreateMaterializedTable.getColumnList();
+                return !sqlNodeList.getList().isEmpty()
+                        && sqlNodeList.getList().get(0) instanceof 
SqlRegularColumn;

Review Comment:
   > as the schema is actually defined in the columns associated with the table 
not the select (query)
   
   this I didn't get
   in a query there might be multiple tables
   schema is associated with materialized table and could also contain 
constraint, watermark, metadata column information which is not retrievable 
from query



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to