snuyanzin commented on code in PR #27793: URL: https://github.com/apache/flink/pull/27793#discussion_r2965032417
########## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampFunction.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.functions.scalar; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.data.StringData; +import org.apache.flink.table.data.TimestampData; +import org.apache.flink.table.functions.BuiltInFunctionDefinitions; +import org.apache.flink.table.functions.SpecializedFunction; +import org.apache.flink.table.utils.DateTimeUtils; + +import javax.annotation.Nullable; + +import static org.apache.flink.table.utils.DateTimeUtils.parseTimestampData; + +/** + * Implementation of {@link BuiltInFunctionDefinitions#TO_TIMESTAMP}. + * + * <p>Supported function signatures: + * + * <ul> + * <li>{@code TO_TIMESTAMP(string)} -> TIMESTAMP(3) <br> + * Parses string timestamp using default format 'yyyy-MM-dd HH:mm:ss' + * <li>{@code TO_TIMESTAMP(string, format)} -> TIMESTAMP(precision) <br> + * Parses string timestamp using the given format. Output precision is inferred from the + * format pattern's trailing 'S' count, with a minimum of 3 for backward compatibility. + * </ul> + */ +@Internal +public class ToTimestampFunction extends BuiltInScalarFunction { + + public ToTimestampFunction(SpecializedFunction.SpecializedContext context) { + super(BuiltInFunctionDefinitions.TO_TIMESTAMP, context); + } + + public @Nullable TimestampData eval(StringData timestamp) { Review Comment: ```suggestion public @Nullable TimestampData eval(@Nullable StringData timestamp) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
