watsonjo737 commented on code in PR #4156:
URL: https://github.com/apache/flink-cdc/pull/4156#discussion_r2965817308
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/DebeziumUtils.java:
##########
@@ -93,13 +111,27 @@ public static MySqlConnection createMySqlConnection(
}
/** Creates a new {@link BinaryLogClient} for consuming mysql binlog. */
- public static BinaryLogClient createBinaryClient(Configuration
dbzConfiguration) {
+ public static BinaryLogClient createBinaryClient(
+ Configuration dbzConfiguration, MySqlConnection connection) {
final MySqlConnectorConfig connectorConfig = new
MySqlConnectorConfig(dbzConfiguration);
- return new BinaryLogClient(
- connectorConfig.hostname(),
- connectorConfig.port(),
- connectorConfig.username(),
- connectorConfig.password());
+ BinaryLogClient client =
+ new BinaryLogClient(
+ connectorConfig.hostname(),
+ connectorConfig.port(),
+ connectorConfig.username(),
+ connectorConfig.password());
+ SSLMode sslMode = sslModeFor(connectorConfig.sslMode());
+ if (sslMode != null) {
Review Comment:
Hi @ruanhang1993 , Makes sense I have updated the function. It now throws in
the default case when it is any unexpected value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
