[
https://issues.apache.org/jira/browse/FLINK-39292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18067603#comment-18067603
]
RocMarshal commented on FLINK-39292:
------------------------------------
Thanks [~lincoln.86xy]
That's reasonable.
> Split BuiltInFunctionDefinitions to reduce the lines of code file to avoid
> reaching code check style limitation
> ---------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-39292
> URL: https://issues.apache.org/jira/browse/FLINK-39292
> Project: Flink
> Issue Type: Technical Debt
> Affects Versions: 2.3.0
> Reporter: RocMarshal
> Priority: Major
>
> Issue & motivation:
> after merging [FLINK-38988][table] Support INET_ATON and INET_NTOA functions
> for IP address conversion.
> Here was a issue:
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=73460&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb
> 09:02:23.973 [ERROR]
> src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:[1]
> (sizes) FileLength: File length is 3,102 lines (max allowed is 3,100).
> The candidate solution:
> Split the functions in BuiltInFunctionDefinitions to the new class file, at
> the same time, we'd guarantee backward compatibility.
> For example, the construction logic of built-in functions can be organized
> into different class files based on their categories, while
> BuiltInFunctionDefinitions only maintains their references and declarations.
>
>
> CC [~twalthr] [~twalthr] [~Jiangang] [~lincoln.86xy]
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
