snuyanzin commented on code in PR #27776: URL: https://github.com/apache/flink/pull/27776#discussion_r2976083448
########## AGENTS.md: ########## @@ -0,0 +1,329 @@ +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +# Flink AI Agent Instructions + +This file provides guidance for AI coding agents working with the Apache Flink codebase. + +## Prerequisites + +- Java 11, 17 (default), or 21. Java 11 syntax must be used in all modules. Java 17 syntax (records, sealed classes, pattern matching) is only permitted in the `flink-tests-java17` module. +- Maven 3.8.6 (Maven wrapper `./mvnw` included; prefer it) +- Git +- Unix-like environment (Linux, macOS, WSL, Cygwin) + +## Commands + +### Build + +- Full build (Java 17 default): `./mvnw clean package -DskipTests -Djdk17 -Pjava17-target` Review Comment: >The -Djdk17, -Djdk11, -Djdk21 flags don't exist as properties in the root pom.xml. Only the -P profiles exist (java17-target, java11-target, java21-target). An agent following these commands would pass a useless flag silently. @gustavodemorais such property doesn't need to be present as @raminqaf mentioned it is in activation, meaning it is enough to pass it to maven to activate profile see for more details https://maven.apache.org/guides/introduction/introduction-to-profiles.html#properties so I would keep all the flags >-Djdk17, -Djdk11, -Djdk21 flags -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
