raminqaf commented on code in PR #27793:
URL: https://github.com/apache/flink/pull/27793#discussion_r2980491611
##########
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/nodes/exec/stream/PythonGroupWindowAggregateJsonPlanTest_jsonplan/testEventTimeSessionWindow.out:
##########
@@ -31,7 +31,7 @@
} ],
"type" : "TIMESTAMP(3)"
},
- "serializableString" : "TO_TIMESTAMP(`c`)"
+ "serializableString" : "`TO_TIMESTAMP`(`c`)"
Review Comment:
This change is a side effect of migrating `TO_TIMESTAMP` from the legacy
`FlinkSqlOperatorTable + StringCallGen` code generation path to the modern
`BridgingSqlFunction` + `runtimeClass` pattern (matching how `TO_TIMESTAMP_LTZ`
is
[implemented](https://github.com/raminqaf/flink/blob/b798f98cc58eb9e54d7d735e90ef4ca7efe0f14e/flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-watermark-assigner_1/watermark-assigner-pushdown-computed/plan/watermark-assigner-pushdown-computed.json#L38-L38)).
The serializableString is produced by
`CallExpression.asSerializableString()`. When the function is resolved through
FunctionCatalog (the bridging path), the serialization goes through
`getSerializableFunctionName() → EncodingUtils.escapeIdentifier()`, which wraps
identifiers in backticks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
