lvyanquan commented on code in PR #4292:
URL: https://github.com/apache/flink-cdc/pull/4292#discussion_r2981236431
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oracle/src/main/java/org/apache/flink/cdc/connectors/oracle/utils/OracleSchemaUtils.java:
##########
@@ -158,7 +158,7 @@ public static Schema getSchema(
DataType dataType = OracleTypeUtils.fromDbzColumn(column);
org.apache.flink.cdc.common.schema.Column cdcColumn =
org.apache.flink.cdc.common.schema.Column.physicalColumn(
- column.name().toLowerCase(Locale.ROOT), dataType);
+ column.name(), dataType);
Review Comment:
It's better to use the same method with
https://github.com/apache/flink-cdc/blob/283edb6506b95ae93dff165bff52df81966cfd7e/flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oracle/src/main/java/org/apache/flink/cdc/connectors/oracle/source/parser/BaseParserListener.java#L90
Perhaps we can extract it as a utility method, if in the future we want to
add parameters to control whether capitalization is handled here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
