eemario commented on code in PR #27755:
URL: https://github.com/apache/flink/pull/27755#discussion_r2985355246


##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java:
##########
@@ -153,7 +153,7 @@ public JobGraph(String jobName) {
     public JobGraph(@Nullable JobID jobId, @Nullable ApplicationID 
applicationId, String jobName) {
         this.jobID = jobId == null ? new JobID() : jobId;
         this.jobName = jobName == null ? "(unnamed job)" : jobName;
-        this.applicationId = applicationId;
+        this.applicationId = applicationId == null ? new ApplicationID() : 
applicationId;

Review Comment:
   The goal is to ensure that JobMaster tests behave as expected by providing a 
non-null applicationId for the JobGraph. Since setting the applicationId 
directly in production code is inappropriate, this is now handled exclusively 
in test utility methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to