dylanhz commented on PR #27817: URL: https://github.com/apache/flink/pull/27817#issuecomment-4122857752
> @dylanhz Well done！These bitmap functions followed the api design and have complete documentation. Only some minor comments that don't block merging. > > Btw, it would be nice to have an explicit round-trip test chaining BITMAP_BUILD → BITMAP_TO_BYTES → BITMAP_FROM_BYTES → BITMAP_TO_ARRAY in a single expression, an end-to-end chain would catch any subtle serialization asymmetry. @lincoln-lil Thanks for the feedback! The updates have been amended to the corresponding commits: - Commit 1: BitmapBuildFunction now uses Bitmap interface - Commit 5: BitmapToArrayFunction catches Throwable, and an explicit round-trip test has been added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
