RocMarshal commented on code in PR #27826:
URL: https://github.com/apache/flink/pull/27826#discussion_r2992003791
##########
flink-runtime-web/web-dashboard/src/app/pages/job/job-detail/status/job-status.component.ts:
##########
@@ -126,16 +128,31 @@ export class JobStatusComponent implements OnInit,
OnDestroy {
return this.listOfNavigation.findIndex(item => item.path ===
'checkpoints');
}
+ rescalesIndexOfNav(): number {
+ return this.listOfNavigation.findIndex(item => item.path === 'rescales');
+ }
+
private handleJobDetailChanged(data: JobDetailCorrect): void {
this.jobDetail = data;
- const index = this.checkpointIndexOfNav();
- if (data.plan.type == 'STREAMING' && index == -1) {
+ const checkpointNavIndex = this.checkpointIndexOfNav();
+ if (data.plan.type == 'STREAMING' && checkpointNavIndex == -1) {
Review Comment:
Sorry for the lack of clarity in my previous message.
What I meant is that the current changes are primarily aimed at adding the
rescale navigation button and the rescales/configuration subpage.
However, it is now apparent that this also includes renaming
checkpoint-related variables.
I prefer that each patch has changes that are as single-purpose or have a
single responsibility as possible.
If you also prefer this approach, we should split the renaming of
checkpoint-related variables into a separate hotfix like
`[[hotfix][runtime-web] Polish the checkpoint related variables naming`.
The other changes can remain in the commit for FLINK-38901.
##########
flink-runtime-web/web-dashboard/src/app/pages/job/job-detail/status/job-status.component.ts:
##########
@@ -126,16 +128,31 @@ export class JobStatusComponent implements OnInit,
OnDestroy {
return this.listOfNavigation.findIndex(item => item.path ===
'checkpoints');
}
+ rescalesIndexOfNav(): number {
+ return this.listOfNavigation.findIndex(item => item.path === 'rescales');
+ }
+
private handleJobDetailChanged(data: JobDetailCorrect): void {
this.jobDetail = data;
- const index = this.checkpointIndexOfNav();
- if (data.plan.type == 'STREAMING' && index == -1) {
+ const checkpointNavIndex = this.checkpointIndexOfNav();
+ if (data.plan.type == 'STREAMING' && checkpointNavIndex == -1) {
Review Comment:
Sorry for the lack of clarity in my previous message.
What I meant is that the current changes are primarily aimed at adding the
rescale navigation button and the rescales/configuration subpage.
However, it is now apparent that this also includes renaming
checkpoint-related variables.
I prefer that each patch has changes that are as single-purpose or have a
single responsibility as possible.
If you also prefer this approach, we should split the renaming of
checkpoint-related variables into a separate hotfix like `[hotfix][runtime-web]
Polish the checkpoint related variables naming`.
The other changes can remain in the commit for FLINK-38901.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
