lvyanquan commented on code in PR #4302:
URL: https://github.com/apache/flink-cdc/pull/4302#discussion_r3014251314
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/io/debezium/connector/mysql/MySqlStreamingChangeEventSource.java:
##########
@@ -1350,6 +1363,15 @@ protected void initSSLContext(SSLContext sc) throws
GeneralSecurityException {
return null;
}
+ private TableIdFilter getTableIdDeserializationFilter() {
+ return tableId -> {
+ // since only subscribed table is recording schema, the result
could be null
+ TableId table = taskContext.getSchema().getTableId(tableId);
+ return table != null
+ &&
connectorConfig.getTableFilters().dataCollectionFilter().isIncluded(table);
Review Comment:
I'm wondering if this filter is necessary. The validation should have
already been done in
[MySqlStreamingChangeEventSource#handleUpdateTableMetadata](https://github.com/apache/flink-cdc/blob/ec244f195b2f7f7f7dc63da4514780b015df0424/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/io/debezium/connector/mysql/MySqlStreamingChangeEventSource.java#L726).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
