[
https://issues.apache.org/jira/browse/FLINK-5504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834166#comment-15834166
]
ASF GitHub Bot commented on FLINK-5504:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3159#discussion_r97283093
--- Diff: flink-dist/src/main/flink-bin/mesos-bin/mesos-appmaster.sh ---
@@ -38,9 +38,14 @@ constructAppMasterClassPath() {
echo $CC_CLASSPATH:$INTERNAL_HADOOP_CLASSPATHS
}
+if [ "$FLINK_IDENT_STRING" = "" ]; then
+ FLINK_IDENT_STRING="$USER"
+fi
+
+
CC_CLASSPATH=`manglePathList $(constructAppMasterClassPath)`
-log=flink-appmaster.log
+log="${FLINK_LOG_DIR}/flink-${FLINK_IDENT_STRING}-mesos-appmaster-${HOSTNAME}.log"
--- End diff --
Looks good. This is inline with the other scripts we have.
---
As a small note: If for some weird reason the `FLINK_LOG_DIR` is not
correctly set, this will try to create the log file in root instead of the
current working directory or something else. Having said that, not relevant for
this PR as it's the same for all scripts.
> mesos-appmaster.sh logs to wrong directory
> ------------------------------------------
>
> Key: FLINK-5504
> URL: https://issues.apache.org/jira/browse/FLINK-5504
> Project: Flink
> Issue Type: Bug
> Components: Mesos
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Fix For: 1.3.0
>
>
> The {{mesos-appmaster.sh}} script does not create the log file under
> {{FLINK_HOME/log}} and does not follow the naming convention. I think we
> should correct the behaviour.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
