[
https://issues.apache.org/jira/browse/FLINK-5532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834177#comment-15834177
]
ASF GitHub Bot commented on FLINK-5532:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/3180#discussion_r97283937
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SlidingAlignedProcessingTimeWindows.java
---
@@ -35,7 +35,7 @@
* <p>
* <b>WARNING:</b> Bear in mind that no rescaling and no backwards
compatibility is supported.
* */
-public class SlidingAlignedProcessingTimeWindows extends
BaseAlignedWindowAssigner {
+public final class SlidingAlignedProcessingTimeWindows extends
BaseAlignedWindowAssigner {
--- End diff --
Yes, they should be `@PublicEvolving`.
Will add that when merging...
> Make the marker WindowAssigners for the fast aligned windows non-extendable.
> ----------------------------------------------------------------------------
>
> Key: FLINK-5532
> URL: https://issues.apache.org/jira/browse/FLINK-5532
> Project: Flink
> Issue Type: Bug
> Components: Windowing Operators
> Affects Versions: 1.2.0
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
> Fix For: 1.2.0
>
>
> This issue refers to the {{SlidingAlignedProcessingTimeWindows}} and
> {{TumblingAlignedProcessingTimeWindows}} and proposes to:
> (1) make the classes {{final}}
> (2) use {{getClass()}} for the check, not {{instanceof()}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
