mateczagany commented on code in PR #159:
URL: https://github.com/apache/flink-shaded/pull/159#discussion_r3177918774


##########
flink-shaded-netty-4/src/main/resources/META-INF/NOTICE:
##########
@@ -6,330 +6,53 @@ The Apache Software Foundation (http://www.apache.org/).
 
 This project bundles the following dependencies under the Apache Software 
License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
 
-- io.netty:netty-all:4.2.6.Final
-- io.netty:netty-buffer:4.2.6.Final
-- io.netty:netty-codec-base:4.2.6.Final
-- io.netty:netty-codec-compression:4.2.6.Final
-- io.netty:netty-codec-classes-quic:4.2.6.Final
-- io.netty:netty-codec-dns:4.2.6.Final
-- io.netty:netty-codec-haproxy:4.2.6.Final
-- io.netty:netty-codec-http3:4.2.6.Final
-- io.netty:netty-codec-http2:4.2.6.Final
-- io.netty:netty-codec-http:4.2.6.Final
-- io.netty:netty-codec-marshalling:4.2.6.Final
-- io.netty:netty-codec-memcache:4.2.6.Final
-- io.netty:netty-codec-mqtt:4.2.6.Final
-- io.netty:netty-codec-native-quic:linux-x86_64:4.2.6.Final
-- io.netty:netty-codec-native-quic:linux-aarch_64:4.2.6.Final
-- io.netty:netty-codec-native-quic:osx-x86_64:4.2.6.Final
-- io.netty:netty-codec-native-quic:osx-aarch_64:4.2.6.Final
-- io.netty:netty-codec-native-quic:windows-x86_64:4.2.6.Final
-- io.netty:netty-codec-redis:4.2.6.Final
-- io.netty:netty-codec-protobuf:4.2.6.Final
-- io.netty:netty-codec-smtp:4.2.6.Final
-- io.netty:netty-codec-socks:4.2.6.Final
-- io.netty:netty-codec-stomp:4.2.6.Final
-- io.netty:netty-codec-xml:4.2.6.Final
-- io.netty:netty-codec:4.2.6.Final
-- io.netty:netty-common:4.2.6.Final
-- io.netty:netty-handler-proxy:4.2.6.Final
-- io.netty:netty-handler-ssl-ocsp:4.2.6.Final
-- io.netty:netty-handler:4.2.6.Final
-- io.netty:netty-resolver-dns-classes-macos:4.2.6.Final
-- io.netty:netty-resolver-dns-native-macos:osx-aarch_64:4.2.6.Final
-- io.netty:netty-resolver-dns-native-macos:osx-x86_64:4.2.6.Final
-- io.netty:netty-resolver-dns:4.2.6.Final
-- io.netty:netty-resolver:4.2.6.Final
-- io.netty:netty-transport-classes-epoll:4.2.6.Final
-- io.netty:netty-transport-classes-io_uring:4.2.6.Final
-- io.netty:netty-transport-classes-kqueue:4.2.6.Final
-- io.netty:netty-transport-native-epoll:linux-aarch_64:4.2.6.Final
-- io.netty:netty-transport-native-epoll:linux-x86_64:4.2.6.Final
-- io.netty:netty-transport-native-epoll:linux-riscv64:4.2.6.Final
-- io.netty:netty-transport-native-io_uring:linux-x86_64:4.2.6.Final
-- io.netty:netty-transport-native-io_uring:linux-aarch_64:4.2.6.Final
-- io.netty:netty-transport-native-io_uring:linux-riscv64:4.2.6.Final
-- io.netty:netty-transport-native-kqueue:osx-aarch_64:4.2.6.Final
-- io.netty:netty-transport-native-kqueue:osx-x86_64:4.2.6.Final
-- io.netty:netty-transport-native-unix-common:4.2.6.Final
-- io.netty:netty-transport-rxtx:4.2.6.Final
-- io.netty:netty-transport-sctp:4.2.6.Final
-- io.netty:netty-transport-udt:4.2.6.Final
-- io.netty:netty-transport:4.2.6.Final
-
-                            The Netty Project

Review Comment:
   There were a few things that had to overrides in the previous NOTICE file 
that came from Netty, but was simply wrong (e.g. BoringSSL was claimed to have 
a BSD license, even though the version used had Apache).
   
   Since these were fixed in the newer Netty release, these overrides can be 
removed. Essentially, with these changes, there are no changes being done to 
the output license, other than the versions themselves.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to