Dennis-Mircea opened a new pull request, #28106:
URL: https://github.com/apache/flink/pull/28106
<!--
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review your
contribution in the best possible way, please go through the checklist below,
which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a
hassle. In order to uphold a high standard of quality for code contributions,
while at the same time managing a large number of contributions, we need
contributors to prepare the contributions well, and give reviewers enough
contextual information for the review. Please also understand that
contributions that do not follow this guide will take longer to review and thus
typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA
issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are
made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the
pull request", where *FLINK-XXXX* should be replaced by the actual issue
number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following
this pattern: `[hotfix] [docs] Fix typo in event time introduction` or
`[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes. You can set up Azure Pipelines CI to do that following [this
guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
(including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This pull request stabilizes four flaky tests that have been observed
failing intermittently on Flink CI. All four flakes have the same root cause
pattern: assertions race against asynchronous bookkeeping or against tasks that
have not yet accumulated enough wall-clock execution time to satisfy the
assertion. The fixes make the tests deterministic without changing any
production behavior.
## Brief change log
- `SplitFetcherManagerTest#testCloseBlockingWaitingForFetcherShutdown`:
replace the strict equality check on the number of fetcher-manager threads (`==
2`) with a polling wait on the element-queue draining thread being started, and
tolerate either `WAITING` or `TIMED_WAITING` states. This removes the timing
assumption that the draining thread has spawned by the time the polling loop
first runs.
-
`RescaleTimelineITCase#testRecordNonTerminatedRescaleMergingWithNewRecoverableFailureTriggerCause`:
when rescale-history is enabled, poll the rescale history until the still-open
`UPDATE_REQUIREMENT` rescale has been merged with the new
`RECOVERABLE_FAILOVER` one before snapshotting the `ExecutionGraphInfo`. The
merge is recorded asynchronously by the scheduler and is not synchronized with
the parallelism / `RUNNING` signals the test waits on.
- `AbstractAsyncRunnableStreamOperatorTest#testCheckpointDrain`: gate the
supplier passed to `asyncProcess` on a `CompletableFuture` that is only
completed after the in-flight-record assertion has run. Previously the request
could complete on a fast machine before the `getInFlightRecordNum() == 1`
check, intermittently observing `0`.
-
`ExecutionTimeBasedSlowTaskDetectorTest#testMultipleJobVertexFinishedTaskExceedRatio`:
insert a short sleep between marking the baseline tasks `FINISHED` and
invoking the detector, so that the still-running tasks have a strictly larger
accumulated execution time than the baseline. On fast machines the whole
sequence could complete within the same millisecond, leaving the running tasks
with `executionTime <= baseline` and producing an empty slow-tasks map.
## Verifying this change
This change is a test-only stabilization without any production-code changes.
It can be verified as follows:
- Each of the four affected tests was executed in a tight loop locally (≥
50 iterations per test, single-threaded and concurrent) and no failures were
observed after the fixes; before the fixes the same loops reproduced the flakes
documented in the linked CI runs.
- For the `RescaleTimelineITCase` and `SplitFetcherManagerTest` cases the
polling waits are bounded by an explicit timeout, so a real regression in the
merge / draining-thread behavior would still surface as a deterministic failure
rather than a hang.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change the checkbox below to `[X]` followed by the name of the tool, and
uncomment the
"Generated-by" line. See the ASF Generative Tooling Guidance for details:
https://www.apache.org/legal/generative-tooling.html
You are responsible for the quality and correctness of every change in this
PR
regardless of the tooling used. Low-effort AI-generated PRs will be closed.
See
AGENTS.md for the full guidance.
-->
- [X] Yes (please specify the tool below)
Generated-by: [Github Copilot]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
