Au-Miner opened a new pull request, #28118:
URL: https://github.com/apache/flink/pull/28118
## What is the purpose of the change
Fix the `topn.cache.size` and `topn.cache.hitRate` metrics in TopN
operators, which were frozen at their initial values and never reflected the
live cache state.
## Brief change log
- Change `AbstractTopNFunction#registerMetric` to accept `LongSupplier`
instead of `long`, so the registered `Gauge` lambdas read the current values on
every poll instead of capturing a snapshot at registration time.
- Update `AppendOnlyTopNHelper`, `FastTop1Helper` and
`UpdatableTopNFunction` call sites to pass suppliers.
## Verifying this change
Added a shared helper `testCacheMetricsReflectLiveState` in
`TopNFunctionTestBase` and overrides in `AppendOnlyTopNFunctionTest`,
`FastTop1FunctionTest` and `UpdatableTopNFunctionTest` that assert the
`topn.cache.size` gauge increases after records are processed.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
找到具有 1 个许可证类型的类似代码
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
