wenjin272 commented on PR #647: URL: https://github.com/apache/flink-agents/pull/647#issuecomment-4384930741
### Code review Found 1 issue: 1. `VectorStoreQuery.filters` is silently dropped in both directions of the Java↔Python bridge. `JavaResourceAdapter.fromPythonVectorStoreQuery` calls the 5-arg `VectorStoreQuery` constructor (whose Javadoc reads "no filters") and never reads the Python object's `filters` attribute. Symmetrically, `python_java_utils.from_java_vector_store_query` builds a Python `VectorStoreQuery` without calling `j_query.getFilters()`. Any query carrying metadata filters crossing the language boundary will silently lose its filter DSL — the resulting query then matches everything in the collection rather than the filtered subset. https://github.com/apache/flink-agents/blob/1ef6e629f17c1dd9404db1b939e15fad7ea4fa1c/runtime/src/main/java/org/apache/flink/agents/runtime/python/utils/JavaResourceAdapter.java#L99-L112 https://github.com/apache/flink-agents/blob/1ef6e629f17c1dd9404db1b939e15fad7ea4fa1c/python/flink_agents/runtime/python_java_utils.py#L254-L263 🤖 Generated with [Claude Code](https://claude.ai/code) <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
