Dennis-Mircea commented on code in PR #28095:
URL: https://github.com/apache/flink/pull/28095#discussion_r3193941732
##########
docs/setup_docs.sh:
##########
@@ -54,10 +54,10 @@ if [ "$SKIP_INTEGRATE_CONNECTOR_DOCS" = false ]; then
integrate_connector_docs elasticsearch v4.0
integrate_connector_docs aws v6.0
integrate_connector_docs cassandra v3.2
- integrate_connector_docs pulsar v4.0
- integrate_connector_docs jdbc v3.1
+ integrate_connector_docs pulsar v4.1
+ integrate_connector_docs jdbc v4.0
integrate_connector_docs rabbitmq v3.0
- integrate_connector_docs gcp-pubsub v3.0
+ integrate_connector_docs gcp-pubsub v3.1
integrate_connector_docs mongodb v2.0
integrate_connector_docs opensearch v1.2
Review Comment:
Thanks for the suggestion! Unfortunately I don't think this bump can be
applied here.
`integrate_connector_docs` uses `git clone --single-branch --branch ${ref}`
(see
[docs/setup_docs.sh#L31](https://github.com/apache/flink/blob/master/docs/setup_docs.sh#L31)),
so the second argument needs to be an existing branch in the connector repo,
matching the vX.Y convention used by the other entries.
Looking at
[apache/flink-connector-opensearch](https://github.com/apache/flink-connector-opensearch/branches/all),
only `v1.0`, `v1.1`, and `v1.2` branches exist and there is no `v2.0` branch
yet. `v2.0.0` is published as a release tag, but using it would break the
branch-based convention the rest of the script follows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
