raminqaf commented on code in PR #28025:
URL: https://github.com/apache/flink/pull/28025#discussion_r3196015680
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/stream/sql/FromChangelogTest.java:
##########
@@ -75,4 +75,18 @@ void testCustomOpMapping() {
+ "error_handling => 'SKIP')",
CHANGELOG_MODE);
}
+
+ @Test
Review Comment:
The upsertKeys will not be printed here. The getPtfUniqueKeys only returns a
value if the changelog mod is upsert. Since we the changelog mode to `retract`
(for now) the upertKeys will not be printed in the plan. Please refer to:
https://github.com/raminqaf/flink/blob/0eef73194ecd47691ad2ce9dc20953b75cfa8f89/flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdUniqueKeys.scala#L697-L704
My suggestion would be to add this later when we are actually adding support
for a different changeLog mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
