[
https://issues.apache.org/jira/browse/FLINK-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834421#comment-15834421
]
ASF GitHub Bot commented on FLINK-5101:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2866#discussion_r97309712
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBase.java
---
@@ -94,5 +122,9 @@ public void close() {
} catch (Exception e) {
LOG.error("Error while closing cluster.", e);
}
+ Throwable e = exception.get();
+ if (e != null) {
+ LOG.error("Error while sending value.", e);
--- End diff --
This needs to be rethrown, otherwise close() may complete without an
exception, but the result may be incomplete.
> Test CassandraConnectorITCase instable
> --------------------------------------
>
> Key: FLINK-5101
> URL: https://issues.apache.org/jira/browse/FLINK-5101
> Project: Flink
> Issue Type: Bug
> Components: Cassandra Connector
> Reporter: Stefan Richter
> Assignee: Chesnay Schepler
>
> I observed this test fail on Travis (very rarely):
>
> Running
> org.apache.flink.streaming.connectors.cassandra.CassandraConnectorITCase
> Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 80.843 sec
> <<< FAILURE! - in
> org.apache.flink.streaming.connectors.cassandra.CassandraConnectorITCase
> testCassandraBatchFormats(org.apache.flink.streaming.connectors.cassandra.CassandraConnectorITCase)
> Time elapsed: 5.82 sec <<< FAILURE!
> java.lang.AssertionError: expected:<40> but was:<20>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at
> org.apache.flink.streaming.connectors.cassandra.CassandraConnectorITCase.testCassandraBatchFormats(CassandraConnectorITCase.java:442)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
