Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2866#discussion_r97309082
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBase.java
---
@@ -69,17 +87,27 @@ public void onFailure(Throwable t) {
@Override
public void invoke(IN value) throws Exception {
- if (exception != null) {
- throw new IOException("invoke() failed", exception);
+ Throwable e = exception.get();
+ if (e != null) {
+ throw new IOException("Error while sending value.", e);
}
ListenableFuture<V> result = send(value);
+ updatesPending.incrementAndGet();
Futures.addCallback(result, callback);
}
public abstract ListenableFuture<V> send(IN value);
@Override
public void close() {
+ while (updatesPending.get() > 0) {
+ synchronized (updatesPending) {
+ try {
+ updatesPending.wait();
+ } catch (InterruptedException e) {
+ }
--- End diff --
Good practice is to set the interruption flag back:
`Thread.currentThread().interrupt();`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
