sd4324530 commented on PR #4368: URL: https://github.com/apache/flink-cdc/pull/4368#issuecomment-4412811052
> Overall, +1 for the change. > > It would be better if you could add an e2e test for this. @lvyanquan Hi, e2e test have been added. When I ran the e2e test, I found that the default value of the config option 'record.size.max.bytes' was incorrect. I've fixed it. see: flink1.20: https://github.com/apache/flink/blob/release-1.20.3/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java#L363-L366 flink2.2: https://github.com/apache/flink/blob/release-2.2.0/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java#L262-L265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
