Savonitar commented on code in PR #247:
URL:
https://github.com/apache/flink-connector-kafka/pull/247#discussion_r3213790628
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/ExactlyOnceKafkaWriter.java:
##########
@@ -268,6 +268,7 @@ private List<KafkaWriterState> createSnapshots(
@Override
public void close() throws Exception {
+ markClosed();
Review Comment:
Shouldn't we add a regression test?
##########
.github/workflows/weekly.yml:
##########
@@ -33,7 +33,7 @@ jobs:
flink: 2.2-SNAPSHOT,
branch: main
}, {
- flink: 2.1.1,
Review Comment:
Could you please add a note to the PR description about the version choices?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
