Samrat002 commented on code in PR #27921:
URL: https://github.com/apache/flink/pull/27921#discussion_r3223411992
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/StateTransitionManager.java:
##########
@@ -89,5 +89,24 @@ interface Context extends RescaleContext {
* @return the {@link JobID} of the job
*/
JobID getJobId();
+
+ /**
+ * Requests the context to actively trigger a checkpoint to expedite
rescaling. Called by
+ * the {@link DefaultStateTransitionManager} from within phase
lifecycle methods:
+ *
+ * <ul>
+ * <li>On entering {@link DefaultStateTransitionManager.Stabilizing}
(to overlap
+ * checkpoint with the stabilization wait)
+ * <li>On each {@link
DefaultStateTransitionManager.Stabilizing#onChange} event (retry if
+ * a previous trigger was skipped)
+ * <li>On entering {@link DefaultStateTransitionManager.Stabilized}
(fallback if no
+ * checkpoint completed during stabilization)
+ * </ul>
+ *
+ * <p>The implementation decides whether to actually trigger based on
its own guard
+ * conditions (e.g., checkpointing enabled, no checkpoint in progress,
config flag).
+ * Multiple calls are safe; guards prevent redundant triggers.
Review Comment:
Moved them to `DefaultStateTransitionManager#requestActiveCheckpointTrigger`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
