Au-Miner opened a new pull request, #28145:
URL: https://github.com/apache/flink/pull/28145
## What is the purpose of the change
Fix the SQL Client REPL becoming unresponsive when connected to a remote SQL
Gateway because a blocking session-config request was issued on every key
press. The change keeps interactive highlighting responsive while still picking
up session configuration updates after statements are executed.
## Brief change log
- Update `SqlClientSyntaxHighlighter#highlight` to use cached session
configuration instead of calling `Executor#getSessionConfig()` on every
highlight invocation, and add `updateSessionConfig(...)` to refresh that cache
safely.
- Wire `CliClient#createLineReader` and `SqlMultiLineParser#parse` so the
syntax highlighter is refreshed with the latest session configuration after an
accepted statement has been executed.
## Verifying this change
Added `SqlClientSyntaxHighlighterTest` to verify that repeated highlighting
does not refetch session config on each input, that executing a `SET` statement
refreshes the cached configuration, and that null refreshes do not overwrite
the existing cache.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
