gaborgsomogyi commented on code in PR #28126:
URL: https://github.com/apache/flink/pull/28126#discussion_r3226306050
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/S3ClientProvider.java:
##########
@@ -348,10 +348,8 @@ public Builder assumeRoleExternalId(@Nullable String
assumeRoleExternalId) {
return this;
}
- public Builder assumeRoleSessionName(@Nullable String
assumeRoleSessionName) {
- if (assumeRoleSessionName != null) {
- this.assumeRoleSessionName = assumeRoleSessionName;
- }
+ public Builder assumeRoleSessionName(String assumeRoleSessionName) {
+ this.assumeRoleSessionName = assumeRoleSessionName;
Review Comment:
I think precondition is missing here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
