yanbinyang commented on code in PR #663:
URL: https://github.com/apache/flink-agents/pull/663#discussion_r3239172607


##########
docs/content/docs/development/vector_stores.md:
##########
@@ -41,6 +41,7 @@ In Flink Agents, vector stores are essential for:
 
 ### Concepts
 * **Document**: Document is the abstraction that represents a piece of text 
and associated metadata. A document may also carry a pre-computed `embedding` 
vector and a `score` populated by query results.
+* **Collection**: Collection is the abstraction that represents a set of 
documents. It corresponds to different concept for different vector store 
specification, like index in Elasticsearch/OpenSearch and collection in 
Chroma/Milvus.

Review Comment:
   > It looks like there were some conflicts during the rebase. In a previous 
PR, we removed the `Collection` data structure and this line of description.
   
   Thanks for catching this. Removed the stale `Collection` concept line in 
ae1261a



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to