wenjin272 commented on PR #655:
URL: https://github.com/apache/flink-agents/pull/655#issuecomment-4452438090
Hi, @wzhero1, Ty for your thorough review.
I fixed some design issues and bugs, including
- Skills rewritten as a single discriminated sources:
List<SkillSourceSpec(scheme, params)> + SkillSourceRegistry. Uniform
Java/Python wire format.
- URL / Classpath / Package / FileSystem repos are now sibling
SkillRepository impls composing a shared SkillDirectoryReader. No more
inheritance-as-composition.
- SkillOrigin(scheme, location) attached to every AgentSkill at
registration.
- SkillRepository extends AutoCloseable; SkillManager.close() cascades
through ResourceContextImpl on operator close (failover-safe).
- Duplicate skill names now LOG.warn with both origins; last-write-wins
kept.
- All matching classpath JARs merged via extractClasspathFromJars;
same-path collisions WARN.
- Single-pass zip extract; JAR_URL_PREFIX_LEN named constant.
The remaining issues related to robustness and security will be iterated on
in subsequent phases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
