dylanhz commented on code in PR #28155:
URL: https://github.com/apache/flink/pull/28155#discussion_r3246932538
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArraySortFunction.java:
##########
@@ -109,8 +109,14 @@ public ArraySortComparator(boolean isAscending) {
@Override
public int compare(Object o1, Object o2) {
try {
- boolean isGreater = (boolean) greaterHandle.invoke(o1, o2);
- return isAscending ? (isGreater ? 1 : -1) : (isGreater ? -1 :
1);
+ // Two probes so equal elements return 0 (Comparator contract).
+ if ((boolean) greaterHandle.invoke(o1, o2)) {
+ return isAscending ? 1 : -1;
+ }
+ if ((boolean) greaterHandle.invoke(o2, o1)) {
+ return isAscending ? -1 : 1;
+ }
Review Comment:
I think the `CASE WHEN` approach might fit this PR better.
An internal compare function/expression could be a good long-term direction
for unifying ordering semantics, but it probably needs broader discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
