Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3178#discussion_r97324700
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/StateSnapshotContextSynchronousImpl.java
---
@@ -127,4 +128,38 @@ public OperatorStateCheckpointOutputStream
getRawOperatorStateOutput() throws Ex
return new DoneFuture<>(stream.closeAndGetHandle());
}
-}
\ No newline at end of file
+ private <T extends StreamStateHandle> void
closeAndUnregisterStream(NonClosingCheckpointOutputStream<T> stream) throws
IOException {
+ Preconditions.checkNotNull(stream);
+
+ closableRegistry.unregisterClosable(stream.getDelegate());
+ stream.getDelegate().close();
+ }
+
+ public void close() throws IOException {
--- End diff --
Of course, but you can and should always pick a more specific exception on
the signature of your implementation. If `IOException` or a subclass is
appropriate here, then you could also go with `Closeable` of course.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
