snuyanzin commented on code in PR #39:
URL:
https://github.com/apache/flink-connector-hive/pull/39#discussion_r3254579782
##########
flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/FlinkEmbeddedHiveRunnerExtension.java:
##########
@@ -64,91 +55,54 @@
import static org.reflections.ReflectionUtils.withAnnotation;
/**
- * JUnit 4 runner that runs hive sql on a HiveServer residing in this JVM. No
external dependencies
- * needed. Inspired by StandaloneHiveRunner.java (almost copied).
+ * JUnit 5 extension that runs hive sql on a HiveServer residing in this JVM.
No external
+ * dependencies needed.
*/
-public class FlinkEmbeddedHiveRunner extends BlockJUnit4ClassRunner {
+class FlinkEmbeddedHiveRunnerExtension implements BeforeAllCallback,
AfterAllCallback {
+
+ private static final Logger LOGGER =
+ LoggerFactory.getLogger(FlinkEmbeddedHiveRunnerExtension.class);
- private static final Logger LOGGER =
LoggerFactory.getLogger(FlinkEmbeddedHiveRunner.class);
private HiveShellContainer container;
+ private TemporaryFolder temporaryFolder;
Review Comment:
probably missed in previous iteration
if it is junit5 extension why do we use junit4's class here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
