balassai commented on code in PR #28160:
URL: https://github.com/apache/flink/pull/28160#discussion_r3256723645
##########
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/pekko/PekkoUtils.java:
##########
@@ -352,7 +355,21 @@ private static void addSslRemoteConfig(
.collect(Collectors.joining("\",\"", "[\"",
"\"]"))
: "[]";
- final String sslProtocol =
configuration.get(SecurityOptions.SSL_PROTOCOL);
+ final String sslProtocolsString =
configuration.get(SecurityOptions.SSL_PROTOCOL);
+ final String[] sslProtocolsArray =
+ Arrays.stream(sslProtocolsString.split(","))
+ .map(String::trim)
+ .toArray(String[]::new);
+ // Pekko's ConfigSSLEngineProvider uses the "protocol" field for both
Review Comment:
Agree, removing the comment the method name self explanatory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
