lvyanquan commented on code in PR #4397:
URL: https://github.com/apache/flink-cdc/pull/4397#discussion_r3256820162
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/parser/metadata/TransformSqlOperatorTable.java:
##########
@@ -285,8 +285,10 @@ public SqlSyntax getSyntax() {
SqlTypeTransforms.FORCE_NULLABLE),
null,
OperandTypes.or(
+ // Only "from string" mode supports specifying
formatter.
OperandTypes.family(SqlTypeFamily.STRING),
- OperandTypes.family(SqlTypeFamily.STRING,
SqlTypeFamily.STRING)),
+ OperandTypes.family(SqlTypeFamily.STRING,
SqlTypeFamily.STRING),
+ OperandTypes.family(SqlTypeFamily.TIMESTAMP)),
Review Comment:
It would be better if you could update the related document to specify the
supported parameter types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
