davidradl commented on code in PR #28161:
URL: https://github.com/apache/flink/pull/28161#discussion_r3257810709
##########
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroSerializer.java:
##########
@@ -325,6 +330,30 @@ private void initializeAvro() {
this.avroData = factory.getAvroData();
}
+ private T resolveGenericRecord(T value) throws IOException {
Review Comment:
It would be useful to include a comment as to the intent of this new method.
I assume it is when the generic record does not match the type we think it is ,
due to schema migrtaion.
##########
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroSerializer.java:
##########
@@ -325,6 +330,30 @@ private void initializeAvro() {
this.avroData = factory.getAvroData();
}
+ private T resolveGenericRecord(T value) throws IOException {
Review Comment:
It would be useful to include a comment as to the intent of this new method.
I assume it is when the generic record does not match the type we think it is ,
due to schema migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
