raminqaf commented on code in PR #28189:
URL: https://github.com/apache/flink/pull/28189#discussion_r3258171992
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##########
@@ -1678,15 +1678,11 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL)
public static final BuiltInFunctionDefinition REGEXP_REPLACE =
BuiltInFunctionDefinition.newBuilder()
- .name("regexpReplace")
- .sqlName("REGEXP_REPLACE")
+ .name("REGEXP_REPLACE")
Review Comment:
This changes are required to expose function via the modern
`BridgingSqlFunction` path.
Same convention is already used by `REGEXP_COUNT`, `REGEXP_EXTRACT_ALL`,
`REGEXP_INSTR`, `REGEXP_SUBSTR` (all name("REGEXP_..."). Aligns
`REGEXP_REPLAC`E with the family.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
