[ 
https://issues.apache.org/jira/browse/FLINK-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834618#comment-15834618
 ] 

ASF GitHub Bot commented on FLINK-2980:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3026#discussion_r97313779
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/ExpressionParser.scala
 ---
    @@ -375,15 +393,26 @@ object ExpressionParser extends JavaTokenParsers with 
PackratParsers {
       lazy val prefixFlattening: PackratParser[Expression] =
         FLATTEN ~ "(" ~> composite <~ ")" ^^ { e => Flattening(e) }
     
    +  lazy val prefixGrouping: PackratParser[Expression] =
    --- End diff --
    
    If you add `grouping`, `groupingId` and `groupId` to the 
`FunctionCatalog.builtInFunctions`. We don't need the following lines.


> Add CUBE/ROLLUP/GROUPING SETS operator in Table API.
> ----------------------------------------------------
>
>                 Key: FLINK-2980
>                 URL: https://issues.apache.org/jira/browse/FLINK-2980
>             Project: Flink
>          Issue Type: New Feature
>          Components: Documentation, Table API & SQL
>            Reporter: Chengxiang Li
>            Assignee: Alexander Chermenin
>         Attachments: Cube-Rollup-GroupSet design doc in Flink.pdf
>
>
> Computing aggregates over a cube/rollup/grouping sets of several dimensions 
> is a common operation in data warehousing. It would be nice to have them in 
> Table API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to