Dennis-Mircea commented on code in PR #1112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1112#discussion_r3267606055
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/ValidatorUtils.java:
##########
@@ -36,13 +37,22 @@ public final class ValidatorUtils {
private static final Logger LOG =
LoggerFactory.getLogger(FlinkUtils.class);
+ @VisibleForTesting
public static Set<FlinkResourceValidator>
discoverValidators(FlinkConfigManager configManager) {
Review Comment:
`@Deprecated(forRemoval = false)` is the weaker form (discouraged, not
scheduled for removal), so it actually contradicts the "for future removal"
framing. `@VisibleForTesting` is already the canonical Flink signal for
"internal, test-only", and `ValidatorUtils` is not part of any public API
surface. I went a step further and deleted the single-arg overload outright,
migrating the test call sites to the two-arg variant. Applied the same cleanup
to `MutatorUtils` and `ListenerUtils` for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
