dylanhz commented on code in PR #28189:
URL: https://github.com/apache/flink/pull/28189#discussion_r3272445524
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##########
@@ -1678,15 +1678,11 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL)
public static final BuiltInFunctionDefinition REGEXP_REPLACE =
BuiltInFunctionDefinition.newBuilder()
- .name("regexpReplace")
- .sqlName("REGEXP_REPLACE")
+ .name("REGEXP_REPLACE")
.kind(SCALAR)
- .inputTypeStrategy(
- sequence(
-
logical(LogicalTypeFamily.CHARACTER_STRING),
-
logical(LogicalTypeFamily.CHARACTER_STRING),
-
logical(LogicalTypeFamily.CHARACTER_STRING)))
+
.inputTypeStrategy(SpecificInputTypeStrategies.REGEXP_REPLACE)
.outputTypeStrategy(nullableIfArgs(explicit(DataTypes.STRING())))
Review Comment:
Sorry for the late comment, but I think the return type should stay
nullable, since `REGEXP_REPLACE` can still return `NULL` for invalid
non-literal regexps.
Could you fix this in the next PR? @raminqaf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
