paulo-t commented on PR #4359: URL: https://github.com/apache/flink-cdc/pull/4359#issuecomment-4504687335
Thanks for pointing this out. I checked the latest upstream master before updating the PR. The issue has not been fixed there yet: Oracle, SQLServer, and DB2 scan fetch tasks still read `connectorConfig.getQueryFetchSize()`, while Postgres reads `connectorConfig.getSnapshotFetchSize()`. You are right that `scan.snapshot.fetch.size` should map to Debezium\s snapshot fetch-size semantics. Mapping it to `query.fetch.size` would make the current Oracle/SQLServer/DB2 code path effective, but it is not semantically correct. I have updated the PR accordingly: - Oracle / SQLServer / DB2 scan fetch tasks now use `connectorConfig.getSnapshotFetchSize()`. - Oracle / SQLServer / DB2 config factories now propagate Flink CDC `scan.snapshot.fetch.size` to Debezium `snapshot.fetch.size`. - The related unit tests now assert `snapshot.fetch.size` and `getSnapshotFetchSize()`. - Postgres already used `snapshot.fetch.size` / `getSnapshotFetchSize()`, so it remains consistent with the updated behavior. I also ran the related factory/config tests locally and they passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
